mirror of
https://github.com/OneKeyHQ/bip39.git
synced 2026-05-13 20:25:03 +00:00
Dice entropy conversion to Base 6 is simpler
Old: Every dice roll is reduced by 1 New: Replace all 6s with 0s
This commit is contained in:
+4
-3
@@ -68,15 +68,16 @@ window.Entropy = new (function() {
|
||||
// Find type of entropy being used (binary, hex, dice etc)
|
||||
var base = getBase(rawEntropyStr);
|
||||
// Convert dice to base6 entropy (ie 1-6 to 0-5)
|
||||
// This is done by changing all 6s to 0s
|
||||
if (base.str == "dice") {
|
||||
var newRawEntropyStr = "";
|
||||
for (var i=0; i<rawEntropyStr.length; i++) {
|
||||
var c = rawEntropyStr[i];
|
||||
if ("123456".indexOf(c) > -1) {
|
||||
newRawEntropyStr += (parseInt(c) - 1).toString();
|
||||
if ("12345".indexOf(c) > -1) {
|
||||
newRawEntropyStr += c;
|
||||
}
|
||||
else {
|
||||
newRawEntropyStr += c
|
||||
newRawEntropyStr += "0";
|
||||
}
|
||||
}
|
||||
rawEntropyStr = newRawEntropyStr;
|
||||
|
||||
@@ -2072,7 +2072,7 @@ page.open(url, function(status) {
|
||||
// dice entropy is converted to base6
|
||||
try {
|
||||
e = Entropy.fromString("123456");
|
||||
if (e.cleanStr != "012345") {
|
||||
if (e.cleanStr != "123450") {
|
||||
return "Dice entropy is not automatically converted to base6";
|
||||
}
|
||||
}
|
||||
@@ -2444,7 +2444,7 @@ page.open(url, function(status) {
|
||||
var entropyText = page.evaluate(function() {
|
||||
return $(".entropy-container").text();
|
||||
});
|
||||
if (entropyText.indexOf("012345") == -1) {
|
||||
if (entropyText.indexOf("123450") == -1) {
|
||||
console.log("Dice entropy is not shown to user as base 6 value");
|
||||
fail();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user