Update CHANGELOG.md

core: remove unused TEMP_DIR mktemp leak in build_container / clean sonarqube (#13708 )
* fix(core): remove unused TEMP_DIR mktemp leak in build_container The build_container() function created a temp directory via mktemp -d and pushd into it, but never popd or rm -rf. The directory was not used for anything — FUNCTIONS_FILE_PATH is downloaded into a variable, not a file. Remove the mktemp -d and pushd entirely to eliminate the leak. * fix(sonarqube): clean up temp file after zip extraction The SonarQube update function (ct/sonarqube.sh) never deleted the downloaded zip file (~200-500 MB) from /tmp after extraction. On LXC containers with 4-8 GB disks, this accumulates with every update and can eventually fill the disk. Also add explicit cleanup in the install script instead of relying solely on cleanup_lxc() pattern matching.
2026-04-13 14:02:16 +00:00 · 2026-04-13 14:00:00 +00:00 · 2026-04-13 15:59:42 +02:00 · 2026-04-13 13:56:13 +00:00 · 2026-04-13 15:55:46 +02:00
6 changed files with 41 additions and 37 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -446,10 +446,18 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

 ### 🚀 Updated Scripts

+  - #### 🐞 Bug Fixes
+
+    - Bambuddy: preserve database and archive on update [@Copilot](https://github.com/Copilot) ([#13706](https://github.com/community-scripts/ProxmoxVE/pull/13706))
+
  - #### ✨ New Features

    - OpenCloud: pin version to 6.0.0 [@vhsdream](https://github.com/vhsdream) ([#13691](https://github.com/community-scripts/ProxmoxVE/pull/13691))

+  - #### 🔧 Refactor
+
+    - core: remove unused TEMP_DIR mktemp leak in build_container / clean sonarqube [@MickLesk](https://github.com/MickLesk) ([#13708](https://github.com/community-scripts/ProxmoxVE/pull/13708))
+
 ## 2026-04-12

 ### 🚀 Updated Scripts
--- a/ct/bambuddy.sh
+++ b/ct/bambuddy.sh
@@ -39,6 +39,9 @@ function update_script() {
    msg_info "Backing up Configuration and Data"
    cp /opt/bambuddy/.env /opt/bambuddy.env.bak
    cp -r /opt/bambuddy/data /opt/bambuddy_data_bak
+    [[ -f /opt/bambuddy/bambuddy.db ]] && cp /opt/bambuddy/bambuddy.db /opt/bambuddy.db.bak
+    [[ -f /opt/bambuddy/bambutrack.db ]] && cp /opt/bambuddy/bambutrack.db /opt/bambutrack.db.bak
+    [[ -d /opt/bambuddy/archive ]] && cp -r /opt/bambuddy/archive /opt/bambuddy_archive_bak
    msg_ok "Backed up Configuration and Data"

    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "bambuddy" "maziggy/bambuddy" "tarball" "latest" "/opt/bambuddy"
@@ -59,8 +62,14 @@ function update_script() {
    mkdir -p /opt/bambuddy/data
    cp /opt/bambuddy.env.bak /opt/bambuddy/.env
    cp -r /opt/bambuddy_data_bak/. /opt/bambuddy/data/
-    rm -f /opt/bambuddy.env.bak
-    rm -rf /opt/bambuddy_data_bak
+    [[ -f /opt/bambuddy.db.bak ]] && cp /opt/bambuddy.db.bak /opt/bambuddy/bambuddy.db
+    [[ -f /opt/bambutrack.db.bak ]] && cp /opt/bambutrack.db.bak /opt/bambuddy/bambutrack.db
+    if [[ -d /opt/bambuddy_archive_bak ]]; then
+      mkdir -p /opt/bambuddy/archive
+      cp -r /opt/bambuddy_archive_bak/. /opt/bambuddy/archive/
+    fi
+    rm -f /opt/bambuddy.env.bak /opt/bambuddy.db.bak /opt/bambutrack.db.bak
+    rm -rf /opt/bambuddy_data_bak /opt/bambuddy_archive_bak
    msg_ok "Restored Configuration and Data"

    msg_info "Starting Service"
--- a/ct/bytestash.sh
+++ b/ct/bytestash.sh
@@ -29,41 +29,28 @@ function update_script() {
    exit
  fi
  if check_for_gh_release "bytestash" "jordan-dalby/ByteStash"; then
-    msg_info "Stopping Services"
-    systemctl stop bytestash-backend bytestash-frontend
-    msg_ok "Services Stopped"
+    read -rp "${TAB3}Did you make a backup via application WebUI? (y/n): " backuped
+    if [[ "$backuped" =~ ^[Yy]$ ]]; then
+      msg_info "Stopping Services"
+      systemctl stop bytestash-backend bytestash-frontend
+      msg_ok "Services Stopped"

-    msg_info "Backing up data"
-    tmp_dir="/opt/bytestash-data-backup"
-    mkdir -p "$tmp_dir"
-    if [[ -d /opt/bytestash/data ]]; then
-      cp -r /opt/bytestash/data "$tmp_dir"/data
-    elif [[ -d /opt/data ]]; then
-      cp -r /opt/data "$tmp_dir"/data
+      CLEAN_INSTALL=1 fetch_and_deploy_gh_release "bytestash" "jordan-dalby/ByteStash" "tarball"
+
+      msg_info "Configuring ByteStash"
+      cd /opt/bytestash/server
+      $STD npm install
+      cd /opt/bytestash/client
+      $STD npm install
+      msg_ok "Updated ByteStash"
+
+      msg_info "Starting Services"
+      systemctl start bytestash-backend bytestash-frontend
+      msg_ok "Started Services"
+    else
+      msg_error "PLEASE MAKE A BACKUP FIRST!"
+      exit
    fi
-    msg_ok "Data backed up"
-
-    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "bytestash" "jordan-dalby/ByteStash" "tarball"
-
-    msg_info "Restoring data"
-    if [[ -d "$tmp_dir"/data ]]; then
-      mkdir -p /opt/bytestash/data
-      cp -r "$tmp_dir"/data/* /opt/bytestash/data/
-      rm -rf "$tmp_dir"
-    fi
-    msg_ok "Data restored"
-
-    msg_info "Configuring ByteStash"
-    cd /opt/bytestash/server
-    $STD npm install
-    cd /opt/bytestash/client
-    $STD npm install
-    msg_ok "Updated ByteStash"
-
-    msg_info "Starting Services"
-    systemctl start bytestash-backend bytestash-frontend
-    msg_ok "Started Services"
-
    msg_ok "Updated successfully!"
  fi
  exit
--- a/ct/sonarqube.sh
+++ b/ct/sonarqube.sh
@@ -43,6 +43,7 @@ function update_script() {
    RELEASE=$(get_latest_github_release "SonarSource/sonarqube")
    curl -fsSL "https://binaries.sonarsource.com/Distribution/sonarqube/sonarqube-${RELEASE}.zip" -o $temp_file
    unzip -q "$temp_file" -d /opt
+    rm -f "$temp_file"
    mv /opt/sonarqube-${RELEASE} /opt/sonarqube
    echo "${RELEASE}" > ~/.sonarqube
    msg_ok "Updated SonarQube"
--- a/install/sonarqube-install.sh
+++ b/install/sonarqube-install.sh
@@ -21,6 +21,7 @@ temp_file=$(mktemp)
 RELEASE=$(get_latest_github_release "SonarSource/sonarqube")
 curl -fsSL "https://binaries.sonarsource.com/Distribution/sonarqube/sonarqube-${RELEASE}.zip" -o $temp_file
 unzip -q "$temp_file" -d /opt
+rm -f "$temp_file"
 mv /opt/sonarqube-* /opt/sonarqube
 $STD useradd -r -m -U -d /opt/sonarqube -s /bin/bash sonarqube
 chown -R sonarqube:sonarqube /opt/sonarqube
--- a/misc/build.func
+++ b/misc/build.func
@@ -3613,8 +3613,6 @@ build_container() {
  fi

  # Build PCT_OPTIONS as string for export
-  TEMP_DIR=$(mktemp -d)
-  pushd "$TEMP_DIR" >/dev/null
  local _func_url
  if [ "$var_os" == "alpine" ]; then
    _func_url="https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/alpine-install.func"
Author	SHA1	Message	Date
github-actions[bot]	ca3b9a30e3	Update CHANGELOG.md	2026-04-13 14:00:00 +00:00
CanbiZ (MickLesk)	e55fe43e2d	core: remove unused TEMP_DIR mktemp leak in build_container / clean sonarqube (#13708 ) * fix(core): remove unused TEMP_DIR mktemp leak in build_container The build_container() function created a temp directory via mktemp -d and pushd into it, but never popd or rm -rf. The directory was not used for anything — FUNCTIONS_FILE_PATH is downloaded into a variable, not a file. Remove the mktemp -d and pushd entirely to eliminate the leak. * fix(sonarqube): clean up temp file after zip extraction The SonarQube update function (ct/sonarqube.sh) never deleted the downloaded zip file (~200-500 MB) from /tmp after extraction. On LXC containers with 4-8 GB disks, this accumulates with every update and can eventually fill the disk. Also add explicit cleanup in the install script instead of relying solely on cleanup_lxc() pattern matching.	2026-04-13 15:59:42 +02:00
community-scripts-pr-app[bot]	482f579dc0	Update CHANGELOG.md (#13710 ) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2026-04-13 13:56:13 +00:00
Copilot	2652ae6c95	Bambuddy: preserve database and archive on update (#13706 ) * Initial plan * fix(bambuddy): backup and restore database and archive directory on update Agent-Logs-Url: https://github.com/community-scripts/ProxmoxVE/sessions/17f6ab31-077b-4215-bc88-eac3187aab0b Co-authored-by: MickLesk <47820557+MickLesk@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MickLesk <47820557+MickLesk@users.noreply.github.com>	2026-04-13 15:55:46 +02:00