controller refactoring part 21

This commit is contained in:
Peter Papp
2021-07-21 17:20:19 +02:00
parent 91fc7f2d9d
commit d55f5c3b41
18 changed files with 360 additions and 319 deletions
@@ -10,6 +10,7 @@ use Domain\Folders\Actions\UpdateFolderPropertyAction;
use Domain\Items\Actions\RenameFileOrFolderAction;
use Domain\Items\Requests\RenameItemRequest;
use Illuminate\Database\Eloquent\Model;
use Support\Demo\Actions\FakeRenameFileOrFolderAction;
class RenameFileOrFolderController extends Controller
{
@@ -20,11 +21,12 @@ class RenameFileOrFolderController extends Controller
RenameItemRequest $request,
string $id,
RenameFileOrFolderAction $renameFileOrFolder,
UpdateFolderPropertyAction $updateFolderProperty
): Model {
UpdateFolderPropertyAction $updateFolderProperty,
FakeRenameFileOrFolderAction $fakeRenameFileOrFolder,
): Model|array {
if (is_demo_account(Auth::user()?->email)) {
return $this->demo->rename_item($request, $id);
if (is_demo_account(Auth::user()->email)) {
return ($fakeRenameFileOrFolder)($request, $id);
}
// If request contain icon or color, then change it
@@ -0,0 +1,59 @@
<?php
namespace Domain\Items\Controllers;
use App\Http\Controllers\Controller;
use Domain\Items\Actions\DeleteFileOrFolderAction;
use Domain\Items\Actions\MoveFileOrFolderAction;
use Domain\Items\Requests\DeleteItemRequest;
use Domain\Sharing\Models\Share;
use Illuminate\Http\Response;
use Support\Services\HelperService;
/**
* Delete item for guest user with edit permission
*/
class VisitorDeleteFileOrFolderController extends Controller
{
public function __construct(
private HelperService $helper,
private DeleteFileOrFolderAction $deleteFileOrFolder,
) {}
public function __invoke(
DeleteItemRequest $request,
Share $shared,
): Response {
abort_if(
is_demo_account($shared->user->email), 204, 'Done.'
);
// Check ability to access protected share record
$this->helper->check_protected_share_record($shared);
// Check shared permission
if (is_visitor($shared)) {
abort(403);
}
foreach ($request->input('items') as $file) {
// Get file|folder item
$item = get_item($file['type'], $file['id']);
// Check access to requested item
if ($file['type'] === 'folder') {
$this->helper->check_item_access($item->id, $shared);
} else {
$this->helper->check_item_access($item->folder_id, $shared);
}
// Delete item
($this->deleteFileOrFolder)($file, $file['id'], $shared);
}
return response('Done', 204);
}
}
@@ -0,0 +1,64 @@
<?php
namespace Domain\Items\Controllers;
use App\Http\Controllers\Controller;
use Domain\Files\Models\File;
use Domain\Items\Actions\MoveFileOrFolderAction;
use Domain\Items\Requests\MoveItemRequest;
use Domain\Sharing\Models\Share;
use Illuminate\Http\Response;
use Support\Services\HelperService;
/**
* Move item for guest user with edit permission
*/
class VisitorMoveFileOrFolderController extends Controller
{
public function __construct(
private HelperService $helper,
private MoveFileOrFolderAction $moveFileOrFolder,
) {}
public function __invoke(
MoveItemRequest $request,
Share $shared,
): Response {
abort_if(
is_demo_account($shared->user->email), 204, 'Done.'
);
// Check ability to access protected share record
$this->helper->check_protected_share_record($shared);
// Check shared permission
if (is_visitor($shared)) {
abort(403);
}
foreach ($request->input('items') as $item) {
if ($item['type'] === 'folder') {
$this->helper->check_item_access([
$request->input('to_id'), $item['id'],
], $shared);
}
if ($item['type'] !== 'folder') {
$file = File::where('id', $item['id'])
->where('user_id', $shared->user_id)
->firstOrFail();
$this->helper->check_item_access([
$request->input('to_id'), $file->folder_id,
], $shared);
}
}
($this->moveFileOrFolder)($request, $request->to_id);
return response('Done!', 204);
}
}
@@ -0,0 +1,72 @@
<?php
namespace Domain\Items\Controllers;
use App\Http\Controllers\Controller;
use Domain\Folders\Actions\UpdateFolderPropertyAction;
use Domain\Items\Actions\RenameFileOrFolderAction;
use Domain\Items\Requests\RenameItemRequest;
use Domain\Sharing\Models\Share;
use Illuminate\Http\Response;
use Support\Demo\Actions\FakeRenameFileOrFolderAction;
use Support\Services\HelperService;
/**
* Rename item for guest user with edit permission
*/
class VisitorRenameFileOrFolderController extends Controller
{
public function __construct(
private HelperService $helper,
private RenameFileOrFolderAction $renameFileOrFolder,
private UpdateFolderPropertyAction $updateFolderProperty,
private FakeRenameFileOrFolderAction $fakeRenameFileOrFolder,
) {}
public function __invoke(
RenameItemRequest $request,
string $id,
Share $shared,
): Response {
// Return fake renamed item in demo
if (is_demo_account($shared->user->email)) {
return ($this->fakeRenameFileOrFolder)($request, $id);
}
// Check ability to access protected share record
$this->helper->check_protected_share_record($shared);
// Check shared permission
if (is_visitor($shared)) {
abort(403);
}
// Get file|folder item
$item = get_item($request->input('type'), $id);
// Check access to requested item
if ($request->input('type') === 'folder') {
$this->helper->check_item_access($item->id, $shared);
} else {
$this->helper->check_item_access($item->folder_id, $shared);
}
// If request have a change folder icon values set the folder icon
if ($request->input('type') === 'folder' && $request->filled('icon')) {
($this->updateFolderProperty)($request, $id);
}
// Rename item
$item = ($this->renameFileOrFolder)($request, $id);
// Set public url
if ($item->type !== 'folder') {
$item->setPublicUrl($shared->token);
}
return response($item, 201);
}
}