api enhancements

src/Domain/Folders/Controllers/FavouriteController.php

@@ -35,7 +35,7 @@ class FavouriteController extends Controller
     /**
      * Remove folder from user favourites
      */
-    public function destroy(string $id): Response|Collection
+    public function destroy(string $id): Response
     {
         $user = Auth::user();
 

src/Domain/Sharing/Controllers/ShareController.php

@@ -27,7 +27,7 @@ class ShareController extends Controller
     public function store(
         CreateShareRequest $request,
         SendViaEmailAction $sendLinkToEmailAction,
-    ): ShareResource {
+    ): Response {
         $item = get_item($request->input('type'), $request->input('id'));
 
         $this->authorize('owner', $item);
@@ -52,7 +52,7 @@ class ShareController extends Controller
         }
 
         // Return created shared record
-        return new ShareResource($shared);
+        return response(new ShareResource($shared), 201);
     }
 
     /**

src/Domain/Sharing/Requests/CreateShareRequest.php

@@ -24,6 +24,7 @@ class CreateShareRequest extends FormRequest
     public function rules()
     {
         return [
+            'id'         => 'required|string',
             'isPassword' => 'required|boolean',
             'type'       => 'required|string',
             'expiration' => 'integer|nullable',

src/Support/helpers.php

@@ -476,7 +476,7 @@ if (! function_exists('make_single_input')) {
         $data = [];
 
         // Add data to array
-        $data[$request->name] = $request->value;
+        $data[$request->input('name')] = $request->input('value');
 
         // Return input
         return $data;