api refactoring part 2

tests/Domain/UploadRequest/UploadRequestBrowsingTest.php

@@ -47,7 +47,7 @@ class UploadRequestBrowsingTest extends TestCase
 
         $this
             ->actingAs($user)
-            ->getJson("/api/upload-request/$uploadRequest->id/navigation")
+            ->getJson("/api/file-request/$uploadRequest->id/navigation")
             ->assertStatus(200)
             ->assertExactJson([
                 [
@@ -115,7 +115,7 @@ class UploadRequestBrowsingTest extends TestCase
 
         $this
             ->actingAs($user)
-            ->getJson("/api/upload-request/$uploadRequest->id/browse/$root->id")
+            ->getJson("/api/file-request/$uploadRequest->id/browse/$root->id")
             ->assertStatus(200)
             ->assertJsonFragment([
                 'id' => $root->id,
@@ -165,7 +165,7 @@ class UploadRequestBrowsingTest extends TestCase
 
         $this
             ->actingAs($user)
-            ->getJson("/api/upload-request/$uploadRequest->id/browse/$root->id")
+            ->getJson("/api/file-request/$uploadRequest->id/browse/$root->id")
             ->assertStatus(200)
             ->assertJsonFragment([
                 'id' => $root->id,

tests/Domain/UploadRequest/UploadRequestEditingTest.php

@@ -34,7 +34,7 @@ class UploadRequestEditingTest extends TestCase
 
         $this
             ->actingAs($user)
-            ->patchJson("/api/upload-request/$uploadRequest->id/rename/$folder->id", [
+            ->patchJson("/api/file-request/$uploadRequest->id/rename/$folder->id", [
                 'name' => 'Renamed Folder',
                 'type' => 'folder',
             ])
@@ -71,7 +71,7 @@ class UploadRequestEditingTest extends TestCase
 
         $this
             ->actingAs($user)
-            ->patchJson("/api/upload-request/$uploadRequest->id/rename/$file->id", [
+            ->patchJson("/api/file-request/$uploadRequest->id/rename/$file->id", [
                 'name' => 'Renamed File',
                 'type' => 'file',
             ])
@@ -102,7 +102,7 @@ class UploadRequestEditingTest extends TestCase
 
         $this
             ->actingAs($user)
-            ->postJson("/api/upload-request/$uploadRequest->id/create-folder", [
+            ->postJson("/api/file-request/$uploadRequest->id/create-folder", [
                 'name'      => 'New Folder',
                 'parent_id' => $uploadRequest->id,
             ])
@@ -162,7 +162,7 @@ class UploadRequestEditingTest extends TestCase
             });
 
         $this
-            ->postJson("/api/upload-request/$uploadRequest->id/remove", [
+            ->postJson("/api/file-request/$uploadRequest->id/remove", [
                 'items' => [
                     [
                         'id'           => $image->id,
@@ -170,7 +170,7 @@ class UploadRequestEditingTest extends TestCase
                         'force_delete' => true,
                     ],
                 ],
-            ])->assertStatus(204);
+            ])->assertStatus(200);
 
         // Assert primary file was deleted
         Storage::assertMissing("files/$user->id/fake-image.jpeg");
@@ -209,7 +209,7 @@ class UploadRequestEditingTest extends TestCase
         Storage::putFileAs("files/$user->id", $fakeFile, $fakeFile->name);
 
         $this
-            ->postJson("/api/upload-request/$uploadRequest->id/remove", [
+            ->postJson("/api/file-request/$uploadRequest->id/remove", [
                 'items' => [
                     [
                         'id'           => $file->id,
@@ -217,7 +217,7 @@ class UploadRequestEditingTest extends TestCase
                         'force_delete' => true,
                     ],
                 ],
-            ])->assertStatus(204);
+            ])->assertStatus(200);
 
         // Assert primary file was deleted
         Storage::assertMissing("files/$user->id/fake-file.pdf");
@@ -264,7 +264,7 @@ class UploadRequestEditingTest extends TestCase
         Storage::putFileAs("files/$user->id", $fakeFile, $fakeFile->name);
 
         $this
-            ->postJson("/api/upload-request/$uploadRequest->id/remove", [
+            ->postJson("/api/file-request/$uploadRequest->id/remove", [
                 'items' => [
                     [
                         'id'           => $folder->id,
@@ -272,7 +272,7 @@ class UploadRequestEditingTest extends TestCase
                         'force_delete' => true,
                     ],
                 ],
-            ])->assertStatus(204);
+            ])->assertStatus(200);
 
         $this
             ->assertDatabaseMissing('folders', [
@@ -317,7 +317,7 @@ class UploadRequestEditingTest extends TestCase
             ]);
 
         $this
-            ->postJson("/api/upload-request/$uploadRequest->id/move", [
+            ->postJson("/api/file-request/$uploadRequest->id/move", [
                 'to_id' => $folder->id,
                 'items' => [
                     [
@@ -325,7 +325,7 @@ class UploadRequestEditingTest extends TestCase
                         'id'   => $file->id,
                     ],
                 ],
-            ])->assertStatus(204);
+            ])->assertStatus(200);
 
         $this->assertDatabaseHas('files', [
             'id'        => $file->id,

tests/Domain/UploadRequest/UploadRequestTest.php

@@ -42,7 +42,7 @@ class UploadRequestTest extends TestCase
 
         $this
             ->actingAs($user)
-            ->postJson('/api/upload-request', [
+            ->postJson('/api/file-request', [
                 'folder_id' => $folder->id,
                 'email'     => 'howdy@hi5ve.digital',
                 'notes'     => 'Please send me your files...',
@@ -74,7 +74,7 @@ class UploadRequestTest extends TestCase
 
         $this
             ->actingAs($user)
-            ->postJson('/api/upload-request', [
+            ->postJson('/api/file-request', [
                 'folder_id' => $folder->id,
                 'notes'     => 'Please send me your files...',
             ])
@@ -105,7 +105,7 @@ class UploadRequestTest extends TestCase
 
         $this
             ->actingAs($user)
-            ->postJson('/api/upload-request', [
+            ->postJson('/api/file-request', [
                 'folder_id' => $folder->id,
                 'notes'     => 'Please send me your files...',
                 'name'      => 'My name',
@@ -137,7 +137,7 @@ class UploadRequestTest extends TestCase
                 'user_id' => $user->id,
             ]);
 
-        $this->getJson("/api/upload-request/$uploadRequest->id")
+        $this->getJson("/api/file-request/$uploadRequest->id")
             ->assertOk()
             ->assertJsonFragment([
                 'id' => $uploadRequest->id,
@@ -165,7 +165,7 @@ class UploadRequestTest extends TestCase
             ->create('fake-file.pdf', 12000000, 'application/pdf');
 
         $this
-            ->postJson("/api/upload-request/$uploadRequest->id/upload/chunks", [
+            ->postJson("/api/file-request/$uploadRequest->id/upload/chunks", [
                 'name'            => $file->name,
                 'extension'       => 'pdf',
                 'chunk'           => $file,
@@ -209,7 +209,7 @@ class UploadRequestTest extends TestCase
             ->create('fake-file.pdf', 12000000, 'application/pdf');
 
         $this
-            ->postJson("/api/upload-request/$uploadRequest->id/upload/chunks", [
+            ->postJson("/api/file-request/$uploadRequest->id/upload/chunks", [
                 'name'            => $file->name,
                 'extension'       => 'pdf',
                 'chunk'           => $file,
@@ -252,7 +252,7 @@ class UploadRequestTest extends TestCase
             ->create('fake-file.pdf', 12000000, 'application/pdf');
 
         $this
-            ->postJson("/api/upload-request/$uploadRequest->id/upload/chunks", [
+            ->postJson("/api/file-request/$uploadRequest->id/upload/chunks", [
                 'name'            => $file->name,
                 'file'            => $file,
                 'is_last_chunk'   => 1,
@@ -275,12 +275,8 @@ class UploadRequestTest extends TestCase
             ]);
 
         $this
-            ->deleteJson("/api/upload-request/$uploadRequest->id")
-            ->assertStatus(201)
-            ->assertJsonFragment([
-                'id'     => $uploadRequest->id,
-                'status' => 'filled',
-            ]);
+            ->deleteJson("/api/file-request/$uploadRequest->id")
+            ->assertStatus(200);
 
         Notification::assertSentTo($user, UploadRequestFulfilledNotification::class);
     }
@@ -323,7 +319,7 @@ class UploadRequestTest extends TestCase
             ->create('fake-file.pdf', 12000000, 'application/pdf');
 
         $this
-            ->postJson("/api/upload-request/$uploadRequest->id/upload/chunks", [
+            ->postJson("/api/file-request/$uploadRequest->id/upload/chunks", [
                 'name'            => $file->name,
                 'extension'       => 'pdf',
                 'chunk'           => $file,