frontend & backend update

app/Http/Controllers/User/AccountController.php

@@ -44,9 +44,14 @@ class AccountController extends Controller
         );
     }
 
+    /**
+     * Get user invoices
+     *
+     * @return InvoiceCollection
+     */
     public function invoices() {
         return new InvoiceCollection(
-            Auth::user()->invoices
+            Auth::user()->invoices()
         );
     }
 

app/Http/Controllers/User/PaymentCardsController.php

@@ -1,107 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\User;
-
-use App\Http\Controllers\Controller;
-use App\Http\Resources\PaymentCardCollection;
-use App\Http\Resources\PaymentCardResource;
-use App\Http\Resources\PaymentDefaultCardResource;
-use App\Services\PaymentService;
-use App\UserCard;
-use Auth;
-use Illuminate\Http\Request;
-use Laravel\Cashier\PaymentMethod;
-
-class PaymentCardsController extends Controller
-{
-    /**
-     * @var PaymentService
-     */
-    private $payment;
-
-    /**
-     * PaymentCardsController constructor.
-     */
-    public function __construct(PaymentService $payment)
-    {
-        $this->payment = $payment;
-    }
-
-    /**
-     * Update card detail
-     *
-     * @param Request $request
-     * @param $id
-     */
-    public function update(Request $request, $id)
-    {
-        $user = Auth::user();
-
-        // Update DefaultPayment Method
-        $user->updateDefaultPaymentMethod($id);
-
-        // Sync default payment method
-        $user->updateDefaultPaymentMethodFromStripe();
-    }
-
-    /**
-     * Delete user credit card
-     *
-     */
-    public function delete($id)
-    {
-        $user = Auth::user();
-
-        // Get payment method
-        $paymentMethod = $user->findPaymentMethod($id);
-
-        // Delete payment method
-        $paymentMethod->delete();
-
-        // Sync default payment method
-        $user->updateDefaultPaymentMethodFromStripe();
-
-        return response('Done!', 204);
-    }
-
-    /**
-     * Get user payment methods sorted by default and others
-     *
-     * @return array
-     */
-    public function payment_methods()
-    {
-        $user = Auth::user();
-
-        // Get default payment method
-        $defaultPaymentMethodObject = $user->defaultPaymentMethod();
-
-        $defaultPaymentMethod = $defaultPaymentMethodObject instanceof PaymentMethod
-            ? $defaultPaymentMethodObject->asStripePaymentMethod()
-            : $defaultPaymentMethodObject;
-
-        // filter payment methods without default payment
-        $paymentMethods = $user->paymentMethods()->filter(function ($paymentMethod) use ($defaultPaymentMethod) {
-            return $paymentMethod->id !== $defaultPaymentMethod->id;
-        });
-
-        // Get payment methods
-        $paymentMethodsMapped = $paymentMethods->map(function ($paymentMethod) {
-            return $paymentMethod->asStripePaymentMethod();
-        })->values()->all();
-
-        if (is_null($paymentMethodsMapped) && is_null($paymentMethodsMapped)) {
-            return [
-                'default' => null,
-                'others'  => [],
-            ];
-        }
-
-        return [
-            'default' => $defaultPaymentMethod instanceof PaymentMethod
-                ? new PaymentCardResource($defaultPaymentMethod)
-                : new PaymentDefaultCardResource($defaultPaymentMethod),
-            'others'  => new PaymentCardCollection($paymentMethodsMapped),
-        ];
-    }
-}

app/Http/Controllers/User/PaymentMethodsController.php

@@ -0,0 +1,122 @@
+<?php
+
+namespace App\Http\Controllers\User;
+
+use App\Http\Controllers\Controller;
+use App\Http\Resources\PaymentCardCollection;
+use App\Http\Resources\PaymentCardResource;
+use App\Http\Resources\PaymentDefaultCardResource;
+use Auth;
+use Illuminate\Http\Request;
+use Illuminate\Support\Facades\Cache;
+use Laravel\Cashier\PaymentMethod;
+
+class PaymentMethodsController extends Controller
+{
+    /**
+     * Get user payment methods grouped by default and others
+     *
+     * @return array
+     */
+    public function payment_methods()
+    {
+        $user = Auth::user();
+
+        $slug_payment_methods = 'payment-methods-user-' . $user->id;
+        $slug_default_payment_method = 'default-payment-methods-user-' . $user->id;
+
+        if (Cache::has($slug_payment_methods) && Cache::has($slug_default_payment_method)) {
+
+            $defaultPaymentMethod = Cache::get($slug_default_payment_method);
+            $paymentMethodsMapped = Cache::get($slug_payment_methods);
+
+        } else {
+
+            // Get default payment method
+            $defaultPaymentMethod = Cache::rememberForever($slug_default_payment_method, function () use ($user) {
+
+                $defaultPaymentMethodObject = $user->defaultPaymentMethod();
+
+                return $defaultPaymentMethodObject instanceof PaymentMethod
+                    ? $defaultPaymentMethodObject->asStripePaymentMethod()
+                    : $defaultPaymentMethodObject;
+            });
+
+            // filter payment methods without default payment
+            $paymentMethodsMapped = Cache::rememberForever($slug_payment_methods, function () use ($defaultPaymentMethod, $user) {
+
+                $paymentMethods = $user->paymentMethods()->filter(function ($paymentMethod) use ($defaultPaymentMethod) {
+                    return $paymentMethod->id !== $defaultPaymentMethod->id;
+                });
+
+                // Get payment methods
+                return $paymentMethods->map(function ($paymentMethod) {
+                    return $paymentMethod->asStripePaymentMethod();
+                })->values()->all();
+            });
+        }
+
+        if (! $user->card_brand || ! $user->stripe_id || is_null($paymentMethodsMapped) && is_null($paymentMethodsMapped)) {
+            return [
+                'default' => null,
+                'others'  => [],
+            ];
+        }
+
+        return [
+            'default' => $defaultPaymentMethod instanceof PaymentMethod
+                ? new PaymentCardResource($defaultPaymentMethod)
+                : new PaymentDefaultCardResource($defaultPaymentMethod),
+            'others'  => new PaymentCardCollection($paymentMethodsMapped),
+        ];
+    }
+
+    /**
+     * Update default payment method
+     *
+     * @param Request $request
+     * @param $id
+     */
+    public function update(Request $request, $id)
+    {
+        $user = Auth::user();
+
+        // Update DefaultPayment Method
+        $user->updateDefaultPaymentMethod($id);
+
+        // Sync default payment method
+        $user->updateDefaultPaymentMethodFromStripe();
+
+        // Clear cached payment methods
+        cache_forget_many([
+            'payment-methods-user-' . $user->id,
+            'default-payment-methods-user-' . $user->id
+        ]);
+    }
+
+    /**
+     * Delete user payment method
+     *
+     */
+    public function delete($id)
+    {
+        $user = Auth::user();
+
+        // Get payment method
+        $paymentMethod = $user->findPaymentMethod($id);
+
+        // Delete payment method
+        $paymentMethod->delete();
+
+        // Sync default payment method
+        $user->updateDefaultPaymentMethodFromStripe();
+
+        // Clear cached payment methods
+        cache_forget_many([
+            'payment-methods-user-' . $user->id,
+            'default-payment-methods-user-' . $user->id
+        ]);
+
+        return response('Done!', 204);
+    }
+}

app/Http/Controllers/User/SubscriptionController.php

@@ -6,12 +6,12 @@ use App\Http\Controllers\Controller;
 use App\Http\Requests\Subscription\StoreUpgradeAccountRequest;
 use App\Http\Resources\UserSubscription;
 use App\Invoice;
-use App\Services\PaymentService;
 use App\Services\StripeService;
 use Auth;
 use Cartalyst\Stripe\Exception\CardErrorException;
 use Illuminate\Contracts\Routing\ResponseFactory;
 use Illuminate\Http\Request;
+use Illuminate\Support\Facades\Cache;
 use Laravel\Cashier\Exceptions\IncompletePayment;
 use Symfony\Component\HttpKernel\Exception\HttpException;
 
@@ -35,21 +35,29 @@ class SubscriptionController extends Controller
      */
     public function stripe_setup_intent()
     {
-        // Get user
         $user = Auth::user();
 
-        // Create stripe customer if not exist
-        $user->createOrGetStripeCustomer();
-
-        // Return setup intent
-        return $user->createSetupIntent();
+        return $this->stripe->getSetupIntent($user);
     }
 
+    /**
+     * Get user subscription detail
+     *
+     * @return UserSubscription
+     */
     public function show()
     {
-        return new UserSubscription(
-            Auth::user()
-        );
+        $slug_user_subscription = 'subscription-user-' . Auth::id();
+
+        if (Cache::has($slug_user_subscription)) {
+            return Cache::get($slug_user_subscription);
+        }
+
+        return Cache::rememberForever($slug_user_subscription, function () {
+            return new UserSubscription(
+                Auth::user()
+            );
+        });
     }
 
     /**
@@ -69,6 +77,9 @@ class SubscriptionController extends Controller
         // Set user billing
         $user->setBilling($request->input('billing'));
 
+        // Update stripe customer billing info
+        $this->stripe->updateCustomerDetails($user);
+
         // Make subscription
         $this->stripe->createOrReplaceSubscription($request, $user);
 
@@ -77,9 +88,6 @@ class SubscriptionController extends Controller
             'storage_capacity' => $plan['product']['metadata']['capacity']
         ]);
 
-        // Store invoice
-        Invoice::create(get_invoice_data($user, $plan, 'stripe'));
-
         return response('Done!', 204);
     }