controller refactoring part 2

src/Domain/Folders/Controllers/FavouriteController.php

@@ -2,15 +2,13 @@
 namespace Domain\Folders\Controllers;
 
 use Illuminate\Http\Request;
+use Illuminate\Http\Response;
 use App\Http\Controllers\Controller;
 use Illuminate\Support\Facades\Auth;
 use Support\Demo\Actions\DemoService;
 
 class FavouriteController extends Controller
 {
-    /**
-     * FavouriteController constructor.
-     */
     public function __construct(
         public DemoService $demo,
     ) {
@@ -18,19 +16,14 @@ class FavouriteController extends Controller
 
     /**
      * Add folder to user favourites
-     *
-     * @param Request $request
-     * @return \Illuminate\Contracts\Routing\ResponseFactory|\Illuminate\Http\Response
+     * todo: pridat validator ako AddToFavouritesRequest
      */
-    public function store(Request $request)
+    public function store(Request $request): Response
     {
-        // todo: pridat validator ako AddToFavouritesRequest
+        $user = Auth::user();
 
-        foreach ($request->folders as $id) {
-            // Get user & folder
-            $user = Auth::user();
-
-            if (is_demo($user->id)) {
+        foreach ($request->input('folders') as $id) {
+            if (is_demo_account($user->email)) {
                 return $this->demo->favourites($user);
             }
 
@@ -46,21 +39,19 @@ class FavouriteController extends Controller
 
     /**
      * Remove folder from user favourites
-     *
-     * @param $id
-     * @return \Illuminate\Contracts\Routing\ResponseFactory|\Illuminate\Http\Response
      */
-    public function destroy($id)
+    public function destroy(string $id): Response
     {
-        // Get user
         $user = Auth::user();
 
-        if (is_demo($user->id)) {
+        if (is_demo_account($user->email)) {
             return $this->demo->favourites($user);
         }
 
         // Remove folder from user favourites
-        $user->favouriteFolders()->detach($id);
+        $user
+            ->favouriteFolders()
+            ->detach($id);
 
         // Return updated favourites
         return response($user->favouriteFolders, 204);