From ecb4d36d6a2aef7aa8aa438b56642a3eafdd2d05 Mon Sep 17 00:00:00 2001 From: "CanbiZ (MickLesk)" <47820557+MickLesk@users.noreply.github.com> Date: Sat, 11 Apr 2026 23:54:03 +0200 Subject: [PATCH] Crafty Controller: Wait for credentials file instead of fixed sleep (#13670) --- install/crafty-controller-install.sh | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/install/crafty-controller-install.sh b/install/crafty-controller-install.sh index 2f5280407..904332147 100644 --- a/install/crafty-controller-install.sh +++ b/install/crafty-controller-install.sh @@ -67,12 +67,18 @@ Restart=on-failure WantedBy=multi-user.target EOF $STD systemctl enable -q --now crafty-controller -sleep 10 -{ - echo "Crafty-Controller-Credentials" - echo "Username: $(grep -oP '(?<="username": ")[^"]*' /opt/crafty-controller/crafty/crafty-4/app/config/default-creds.txt)" - echo "Password: $(grep -oP '(?<="password": ")[^"]*' /opt/crafty-controller/crafty/crafty-4/app/config/default-creds.txt)" -} >>~/crafty-controller.creds +CREDS_FILE="/opt/crafty-controller/crafty/crafty-4/app/config/default-creds.txt" +for i in $(seq 1 30); do + [[ -f "$CREDS_FILE" ]] && break + sleep 2 +done +if [[ -f "$CREDS_FILE" ]]; then + { + echo "Crafty-Controller-Credentials" + echo "Username: $(grep -oP '(?<="username": ")[^"]*' "$CREDS_FILE")" + echo "Password: $(grep -oP '(?<="password": ")[^"]*' "$CREDS_FILE")" + } >>~/crafty-controller.creds +fi msg_ok "Service started" motd_ssh