nexus/ProxmoxVE
2
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-18 16:32:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

github: improvements for node drift wf (#12309)

Browse Source 
* fix(workflow): improve Node.js version drift detection accuracy

1. Fix source URL regex: now captures 'Github: https://github.com/...'
   pattern (pipe-separated), not just '# Source: https://github.com/...'
   This was causing ~50 scripts to show 'No GitHub source'

2. Fix semver comparison: engines.node constraints like '>=18.0.0'
   no longer flag version 22 as drift. >= and ^ constraints are now
   properly evaluated (our_version >= min_major = satisfied)

3. Add fallback detection: when no Dockerfile or engines.node is found,
   check .nvmrc and .node-version files for Node version hints

4. Add subdirectory search: Dockerfile and package.json are now found
   via GitHub API tree search, not just in repo root

5. Use GitHub API to detect default branch instead of guessing
   main/master/dev with multiple HEAD requests

* fix typos in node_version

* runs on vps
This commit is contained in:
CanbiZ (MickLesk)
2026-02-25 11:27:47 +01:00
committed by GitHub
parent 6df91f54af
commit dd4a15fff1
6 changed files with 137 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
install/pve-scripts-local-install.sh
View File

@@ -21,7 +21,7 @@ $STD apt install -y \
expect
msg_ok "Dependencies installed."
NODE_VERSION=24 setup_nodejs
NODE_VERSION="24" setup_nodejs
fetch_and_deploy_gh_release "ProxmoxVE-Local" "community-scripts/ProxmoxVE-Local" "tarball"
msg_info "Installing PVE Scripts local"