mirror of
https://github.com/community-scripts/ProxmoxVE.git
synced 2026-05-31 13:04:43 +00:00
fix(fileflows): handle node-only update separately from server
The update_script always called the server API at localhost:19200 which does not exist on node-only containers, causing a connection error (exit code 7) or 401 on auth-hardened servers. Fix: detect node vs server via systemctl is-enabled, then: - Node: use GitHub releases API to compare versions and update - Server: keep existing local API behaviour Fixes #14622
This commit is contained in:
+39
-7
@@ -31,11 +31,22 @@ function update_script() {
|
|||||||
exit
|
exit
|
||||||
fi
|
fi
|
||||||
|
|
||||||
update_available=$(curl -fsSL -X 'GET' "http://localhost:19200/api/status/update-available" -H 'accept: application/json' | jq .UpdateAvailable)
|
RELEASE=$(curl -fsSL "https://api.github.com/repos/revenz/FileFlows/releases/latest" | jq -r '.tag_name' | sed 's/^v//')
|
||||||
if [[ "${update_available}" == "true" ]]; then
|
CURRENT=$(cat /opt/fileflows/version 2>/dev/null | tr -d '[:space:]')
|
||||||
|
|
||||||
|
if systemctl is-enabled fileflows-node &>/dev/null && ! systemctl is-enabled fileflows &>/dev/null; then
|
||||||
|
# Node-only installation: no local server API available
|
||||||
|
if [[ -z "$RELEASE" ]]; then
|
||||||
|
msg_error "Failed to retrieve latest ${APP} version"
|
||||||
|
exit
|
||||||
|
fi
|
||||||
|
if [[ "$CURRENT" == "$RELEASE" ]]; then
|
||||||
|
msg_ok "No update required. ${APP} Node is already at v${CURRENT}"
|
||||||
|
exit
|
||||||
|
fi
|
||||||
msg_info "Stopping Service"
|
msg_info "Stopping Service"
|
||||||
systemctl stop fileflows*
|
systemctl stop fileflows-node
|
||||||
msg_info "Stopped Service"
|
msg_ok "Stopped Service"
|
||||||
|
|
||||||
msg_info "Creating Backup"
|
msg_info "Creating Backup"
|
||||||
ls /opt/*.tar.gz &>/dev/null && rm -f /opt/*.tar.gz
|
ls /opt/*.tar.gz &>/dev/null && rm -f /opt/*.tar.gz
|
||||||
@@ -46,11 +57,32 @@ function update_script() {
|
|||||||
fetch_and_deploy_from_url "https://fileflows.com/downloads/zip" "/opt/fileflows"
|
fetch_and_deploy_from_url "https://fileflows.com/downloads/zip" "/opt/fileflows"
|
||||||
|
|
||||||
msg_info "Starting Service"
|
msg_info "Starting Service"
|
||||||
systemctl start fileflows*
|
systemctl start fileflows-node
|
||||||
msg_ok "Started Service"
|
msg_ok "Started Service"
|
||||||
msg_ok "Updated successfully!"
|
msg_ok "Updated successfully to v${RELEASE}!"
|
||||||
else
|
else
|
||||||
msg_ok "No update required. ${APP} is already at latest version"
|
# Server installation: use the local API
|
||||||
|
update_available=$(curl -fsSL -X 'GET' "http://localhost:19200/api/status/update-available" -H 'accept: application/json' | jq .UpdateAvailable)
|
||||||
|
if [[ "${update_available}" == "true" ]]; then
|
||||||
|
msg_info "Stopping Service"
|
||||||
|
systemctl stop fileflows*
|
||||||
|
msg_ok "Stopped Service"
|
||||||
|
|
||||||
|
msg_info "Creating Backup"
|
||||||
|
ls /opt/*.tar.gz &>/dev/null && rm -f /opt/*.tar.gz
|
||||||
|
backup_filename="/opt/${APP}_backup_$(date +%F).tar.gz"
|
||||||
|
tar -czf "$backup_filename" -C /opt/fileflows Data
|
||||||
|
msg_ok "Backup Created"
|
||||||
|
|
||||||
|
fetch_and_deploy_from_url "https://fileflows.com/downloads/zip" "/opt/fileflows"
|
||||||
|
|
||||||
|
msg_info "Starting Service"
|
||||||
|
systemctl start fileflows*
|
||||||
|
msg_ok "Started Service"
|
||||||
|
msg_ok "Updated successfully to v${RELEASE}!"
|
||||||
|
else
|
||||||
|
msg_ok "No update required. ${APP} is already at latest version"
|
||||||
|
fi
|
||||||
fi
|
fi
|
||||||
|
|
||||||
exit
|
exit
|
||||||
|
|||||||
Reference in New Issue
Block a user