nexus/ProxmoxVE
2
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-05-27 19:14:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tools): prevent script crash when entering GitHub token after rate limit

Browse Source 
fetch_and_deploy_gh_release set attempt=0 after accepting a token, then
immediately ran ((0++)) which evaluates to 0 (falsy) causing exit code 1
and killing the script under set -e.

Fix: set attempt=1 and continue to restart the retry loop cleanly,
giving the full max_retries budget with the new token.

Also fix fetch_and_deploy_codeberg_release: replace ((attempt++)) with
attempt=\ to avoid the same zero-evaluation crash on
the first connection timeout (attempt starts at 0 in that loop).

Fixes #13635
This commit is contained in:
CanbiZ (MickLesk)
2026-04-10 09:50:10 +02:00
parent 82cc074b05
commit beb29c00ea
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
misc/tools.func
+3 -2
View File
@@ -2860,7 +2860,7 @@ function fetch_and_deploy_codeberg_release() {
while ((attempt < ${#api_timeouts[@]})); do while ((attempt < ${#api_timeouts[@]})); do
resp=$(curl --connect-timeout 10 --max-time "${api_timeouts[$attempt]}" -fsSL -w "%{http_code}" -o /tmp/codeberg_rel.json "$api_url") && success=true && break resp=$(curl --connect-timeout 10 --max-time "${api_timeouts[$attempt]}" -fsSL -w "%{http_code}" -o /tmp/codeberg_rel.json "$api_url") && success=true && break
((attempt++)) attempt=$((attempt + 1))
if ((attempt < ${#api_timeouts[@]})); then if ((attempt < ${#api_timeouts[@]})); then
msg_warn "API request timed out after ${api_timeouts[$((attempt - 1))]}s, retrying... (attempt $((attempt + 1))/${#api_timeouts[@]})" msg_warn "API request timed out after ${api_timeouts[$((attempt - 1))]}s, retrying... (attempt $((attempt + 1))/${#api_timeouts[@]})"
fi fi
@@ -3370,7 +3370,8 @@ function fetch_and_deploy_gh_release() {
if prompt_for_github_token; then if prompt_for_github_token; then
header=(-H "Authorization: token $GITHUB_TOKEN") header=(-H "Authorization: token $GITHUB_TOKEN")
retry_delay=2 retry_delay=2
attempt=0 attempt=1
continue
fi fi
fi fi
else else