nexus/ProxmoxVE
2
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-05-30 20:44:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(update-apps): add var_continue_on_error and TERM=dumb fix

Browse Source 
- Add var_continue_on_error=yes to skip failed containers instead
  of aborting all remaining updates. Useful for cron/unattended runs
  where one disabled or broken script should not stop others.
  Containers with backup still attempt restore on failure regardless.

- Set TERM=dumb when running pct exec to prevent whiptail from
  hanging when no TTY is available (e.g. cron jobs redirecting
  stdout/stderr). This causes whiptail to fail-fast instead of
  blocking indefinitely.

- Add var_continue_on_error to export_config_json, --help output,
  and usage examples (cron-style invocation example added).
This commit is contained in:
MickLesk
2026-05-05 21:40:01 +02:00
parent a3e147cf20
commit b1148a486f
1 changed files with 26 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/pve/update-apps.sh
+26 -11
View File
@@ -42,6 +42,11 @@ var_skip_confirm="${var_skip_confirm:-no}"
# Options: "yes" | "no" | "" (empty = interactive prompt) # Options: "yes" | "no" | "" (empty = interactive prompt)
var_auto_reboot="${var_auto_reboot:-}" var_auto_reboot="${var_auto_reboot:-}"
# var_continue_on_error: Continue updating remaining containers if one update fails
# Options: "yes" | "no" (default: no = stop on first error)
# Note: containers with backups always attempt restore on failure regardless of this setting
var_continue_on_error="${var_continue_on_error:-no}"
# var_tags: Optionally override the tags used for auto-detection # var_tags: Optionally override the tags used for auto-detection
# Options: "community-script|proxmox-helper-scripts" (default) # Options: "community-script|proxmox-helper-scripts" (default)
var_tags="${var_tags:-community-script|proxmox-helper-scripts}" var_tags="${var_tags:-community-script|proxmox-helper-scripts}"
@@ -59,6 +64,7 @@ function export_config_json() {
"var_unattended": "${var_unattended}", "var_unattended": "${var_unattended}",
"var_skip_confirm": "${var_skip_confirm}", "var_skip_confirm": "${var_skip_confirm}",
"var_auto_reboot": "${var_auto_reboot}", "var_auto_reboot": "${var_auto_reboot}",
"var_continue_on_error": "${var_continue_on_error}",
"var_tags": "${var_tags}" "var_tags": "${var_tags}"
} }
EOF EOF
@@ -78,10 +84,11 @@ Environment Variables:
var_backup Enable backup before update (yes/no) var_backup Enable backup before update (yes/no)
var_backup_storage Storage location for backups var_backup_storage Storage location for backups
var_container Container selection (all/all_running/all_stopped/101,102,...) var_container Container selection (all/all_running/all_stopped/101,102,...)
var_unattended Run updates unattended (yes/no) var_unattended Run updates unattended (yes/no)
var_skip_confirm Skip initial confirmation (yes/no) var_skip_confirm Skip initial confirmation (yes/no)
var_auto_reboot Auto-reboot containers if required (yes/no) var_auto_reboot Auto-reboot containers if required (yes/no)
var_tags Optionally override auto-detection tags ("prod|smb|community-script") var_continue_on_error Continue to next container on update failure (yes/no)
var_tags Optionally override auto-detection tags ("prod|smb|community-script")
Examples: Examples:
# Run interactively # Run interactively
@@ -93,6 +100,9 @@ Examples:
# Update specific containers without backup # Update specific containers without backup
var_backup=no var_container=101,102,105 var_unattended=yes var_skip_confirm=yes $(basename "$0") var_backup=no var_container=101,102,105 var_unattended=yes var_skip_confirm=yes $(basename "$0")
# Unattended cron-style: skip confirm, continue on error, no backup
var_backup=no var_container=all_running var_unattended=yes var_skip_confirm=yes var_continue_on_error=yes $(basename "$0")
# Export current configuration # Export current configuration
$(basename "$0") --export-config $(basename "$0") --export-config
EOF EOF
@@ -397,11 +407,11 @@ for container in $CHOICE; do
#4) Update service, using the update command #4) Update service, using the update command
case "$os" in case "$os" in
alpine) pct exec "$container" -- ash -c "$UPDATE_CMD" ;; alpine) pct exec "$container" -- ash -c "export TERM=dumb;$UPDATE_CMD" ;;
archlinux) pct exec "$container" -- bash -c "$UPDATE_CMD" ;; archlinux) pct exec "$container" -- bash -c "export TERM=dumb;$UPDATE_CMD" ;;
fedora | rocky | centos | alma) pct exec "$container" -- bash -c "$UPDATE_CMD" ;; fedora | rocky | centos | alma) pct exec "$container" -- bash -c "export TERM=dumb;$UPDATE_CMD" ;;
ubuntu | debian | devuan) pct exec "$container" -- bash -c "$UPDATE_CMD" ;; ubuntu | debian | devuan) pct exec "$container" -- bash -c "export TERM=dumb;$UPDATE_CMD" ;;
opensuse) pct exec "$container" -- bash -c "$UPDATE_CMD" ;; opensuse) pct exec "$container" -- bash -c "export TERM=dumb;$UPDATE_CMD" ;;
esac esac
exit_code=$? exit_code=$?
@@ -446,8 +456,13 @@ for container in $CHOICE; do
exit 235 exit 235
fi fi
else else
msg_error "Update failed for container $container. Exiting" msg_error "Update failed for container $container (exit code: $exit_code)"
exit "$exit_code" if [[ "$var_continue_on_error" == "yes" ]]; then
echo -e "${YW}[WARN]${CL} Continuing to next container (var_continue_on_error=yes)"
continue
else
exit "$exit_code"
fi
fi fi
done done