fix(tools.func): replace generic return 1 with specific exit codes

Browse Source

Replace 300 generic 'return 1' error returns with specific exit codes
matching the EXIT_CODES.md schema for better telemetry and debugging:

- 6: DNS resolution failed
- 7: Connection/curl failed
- 22: HTTP/API error (401, 403, 404, etc.)
- 65: Data format/parameter error
- 100: APT package manager error
- 127: Command not found
- 150: Service/build failed
- 236: Hardware not detected
- 238: OS not supported
- 250: Download/version determination failed
- 251: File extraction failed
- 252: File not found

Boolean returns (is_tool_installed, should_update_tool, verify_tool_version,
verify_repo_available, prompt_for_github_token, should_upgrade, is_lts_version,
check_for_*_release 'no update') intentionally kept as return 1.

Affected functions: curl_with_retry, curl_api_with_retry, download_gpg_key,
install_packages_with_retry, upgrade_packages_with_retry, manage_tool_repository,
upgrade_package, github_api_call, codeberg_api_call, setup_deb822_repo,
get_latest_gh_tag, get_latest_github_release, check_for_gh_release,
check_for_codeberg_release, fetch_and_deploy_gh_release,
fetch_and_deploy_codeberg_release, fetch_and_deploy_from_url,
setup_mongodb, setup_mysql, setup_mariadb, setup_nodejs, setup_postgresql,
setup_php, setup_java, setup_go, setup_ruby, setup_rust, setup_uv,
setup_clickhouse, setup_adminer, setup_composer, setup_ffmpeg,
setup_imagemagick, setup_gs, setup_yq, setup_meilisearch, setup_docker,
setup_postgresql_db, setup_mariadb_db, and helper functions.

...

This commit is contained in:

CanbiZ (MickLesk)

2026-03-26 14:50:06 +01:00

parent d06a70819d

commit a53fef912c

1 changed files with 300 additions and 300 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

600

misc/tools.func

File diff suppressed because it is too large Load Diff