From 2258cfb910776946b174809fd0a9526564673aa6 Mon Sep 17 00:00:00 2001
From: MickLesk <mickey.leskowitz@gmail.com>
Date: Sat, 21 Mar 2026 19:18:24 +0100
Subject: [PATCH] fix(build): add missing -searchdomain/-nameserver prefix in
 base_settings

base_settings() set SD and NS as raw values from var_searchdomain/var_ns,
but build_container() expects them with -searchdomain=/-nameserver= prefix.
When using MyDefaults or AppDefaults code paths (which skip
advanced_settings()), the values ended up as unprefixed positional
arguments in the pct create command, causing '400 too many arguments'.

advanced_settings() already added the prefix correctly, so only
default/saved-defaults paths were affected.

Ref #13135
---
 misc/build.func | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/misc/build.func b/misc/build.func
index 97eb9270a..6819744b4 100644
--- a/misc/build.func
+++ b/misc/build.func
@@ -985,8 +985,10 @@ base_settings() {
   fi
 
   MTU=${var_mtu:-""}
-  SD=${var_searchdomain:-""}
-  NS=${var_ns:-""}
+  _sd_val="${var_searchdomain:-""}"
+  [[ -n "$_sd_val" ]] && SD="-searchdomain=$_sd_val" || SD=""
+  _ns_val="${var_ns:-""}"
+  [[ -n "$_ns_val" ]] && NS="-nameserver=$_ns_val" || NS=""
   MAC=${var_mac:-""}
   VLAN=${var_vlan:-""}
   SSH=${var_ssh:-"no"}